Add metric for tracking S3 endpoint calls by RPC method#28
Closed
regexident wants to merge 3 commits intomainfrom
Closed
Add metric for tracking S3 endpoint calls by RPC method#28regexident wants to merge 3 commits intomainfrom
regexident wants to merge 3 commits intomainfrom
Conversation
hasenbanck
reviewed
Mar 13, 2026
src/telemetry.rs
Outdated
|
|
||
| // MARK: - Endpoint Calls | ||
|
|
||
| pub(crate) fn record_endpoint_call(method: &'static str) { |
There was a problem hiding this comment.
This now only measures the total endpoint call count to the endpoints.
But we already use the http.server semantic convention! So we should use the http.client convention here too!
https://opentelemetry.io/docs/specs/semconv/http/http-metrics/#http-client
rpc.method is then just an additional attribute (we add the S3 semantic to the http client semantic). I of course reason that the S3 client uses the http protocol.
AlexanderKlump
force-pushed
the
plat-330/s3-endpoint-metric
branch
from
a835ced to
fa72cab
Compare
AlexanderKlump
force-pushed
the
plat-330/s3-endpoint-metric
branch
from
ac56bcf to
81df8bc
Compare
AlexanderKlump
force-pushed
the
plat-330/s3-endpoint-metric
branch
from
81df8bc to
dc08c79
Compare
timglabisch
reviewed
Mar 17, 2026
| #[async_trait::async_trait] | ||
| impl S3Access for TelemetryAccess { | ||
| async fn check(&self, cx: &mut S3AccessContext<'_>) -> S3Result<()> { | ||
| // to use this check to record telemetry data is an abuse of the S3Access trait, but we use it here to have a single location where we can record the requested operations |
Member
There was a problem hiding this comment.
Die alternative wäre ein decorator für den S3 Trait, oder? bedeutet man müsste alle methoden wrappen.
Contributor
Author
|
Closed in favor of #34 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.